housekeeping: removes fillTokensStoreFromAggregatorData #5943
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dskloetd
approved these changes
Dec 9, 2024
yhabib
deleted the
yhabib/housekeeping/fillTokensStoreFromAggregatorData
branch
yhabib
added a commit
that referenced
this pull request
Dec 9, 2024
# Motivation This function `fillTokensStoreFromAggregatorData` was initially added in #4455 and later removed in #4461. It appears to have been a temporary function that is no longer necessary. # Changes - Removes `fillTokensStoreFromAggregatorData` # Tests - Deletes tests # Todos - [ ] Add entry to changelog (if necessary). Not necessary
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
This function
fillTokensStoreFromAggregatorDatawas initially added in #4455 and later removed in #4461. It appears to have been a temporary function that is no longer necessary.Changes
fillTokensStoreFromAggregatorDataTests
Todos
Not necessary